[Mesa-dev] [PATCH 1/2] mesa: common/meta: avoid printing uninitialized bytes.

Oliver McFadden oliver.mcfadden at linux.intel.com
Wed May 30 04:42:11 PDT 2012


On Tue, May 29, 2012 at 10:27:15AM -0700, Eric Anholt wrote:
> On Sat, 26 May 2012 10:22:16 +0300, Oliver McFadden <oliver.mcfadden at linux.intel.com> wrote:
> > Mesa 8.1-devel implementation error: meta program compile failed:
> > ��
> 
> I think this is the wrong fix.  From the GL 3.0 spec:
> 
>     "These commands return the info log string in infoLog. This string
>      will be null terminated.  The actual number of characters written
>      into infoLog, excluding the null terminator, is returned in
>      length... The number of characters in the info log can be queried
>      with GetShaderiv or GetProgramiv with INFO LOG LENGTH."
> 
> So you just need to malloc size + 1.

OK. I will check this and hold-off on the uninitialized bytes patch.

-- 
Oliver McFadden.


More information about the mesa-dev mailing list