[Mesa-dev] [PATCH] Revert "radeon/llvm: Inital flow control support for SI"

Tom Stellard tom at stellard.net
Mon Oct 1 07:11:35 PDT 2012


On Fri, Sep 28, 2012 at 06:24:13PM +0200, Michel Dänzer wrote:
> From: Michel Dänzer <michel.daenzer at amd.com>
> 
> This reverts commit bfd55711c1eb32ffbfceb9d566abae98f0015f23.
> 
> It makes piglit unreliable due to VM protection faults and GPU lockups.
> 
> Signed-off-by: Michel Dänzer <michel.daenzer at amd.com>
>  src/gallium/drivers/radeon/AMDGPUTargetMachine.cpp |    1 -
>  
> diff --git a/src/gallium/drivers/radeon/AMDGPUTargetMachine.cpp b/src/gallium/drivers/radeon/AMDGPUTargetMachine.cpp
> index 0b70191..c1b6840 100644
> --- a/src/gallium/drivers/radeon/AMDGPUTargetMachine.cpp
> +++ b/src/gallium/drivers/radeon/AMDGPUTargetMachine.cpp
> @@ -134,7 +134,6 @@ bool AMDGPUPassConfig::addPreEmitPass() {
>      addPass(FinalizeMachineBundlesID);
>    } else {
>      PM->add(createSILowerLiteralConstantsPass(*TM));
> -    PM->add(createSILowerFlowControlPass(*TM));
>    }
>  

Instead of reverting the entire commit, you can just tell the
TargetMachine not to add the SILowerFlowControlPass.  It should have the
same effect as a full revert.

With that change:

Reviewed-by: Tom Stellard <thomas.stellard at amd.com>


More information about the mesa-dev mailing list