[Mesa-dev] [PATCH] mesa: allow MESA_GL_VERSION_OVERRIDE to override the API type

[Kenneth Graunke]

On 09/01/2012 10:14 AM, Jordan Justen wrote:
> Change the format to [MAJOR.MINOR][CORE|COMPAT]
> For example: 3.0, CORE, COMPAT, 3.2CORE
> 
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>

Since we aren't going to support compatibility contexts, I would just
make MESA_GL_VERSION_OVERRIDE=3.1 force API_OPENGL_CORE.  It's simpler
to use and less code.

Plus, MESA_GL_VERSION_OVERRIDE=3.2COMPAT is completely useless right
now, as nothing supports it.  If somebody did ever want to implement
compatibility mode (and I am strongly opposed to accepting such
patches), they could add this then.

There's one key semantic difference worth mentioning: previously,
MESA_GL_VERSION_OVERRIDE made the drivers lie and advertise support for
a particular version (even if they normally wouldn't).  Now, I think
you're trying to change it so setting MESA_GL_VERSION_OVERRIDE=3.2CORE
makes it actually /give you/ a 3.2 core context.  That seems useful, and
I agree with the change, I just wanted to point it out.