[Mesa-dev] [PATCH] draw: don't crash if GS doesn't emit anything

Alex Deucher alexdeucher at gmail.com
Tue Apr 30 06:46:45 PDT 2013


On Tue, Apr 30, 2013 at 9:40 AM, Brian Paul <brianp at vmware.com> wrote:
> On 04/27/2013 06:57 AM, Zack Rusin wrote:
>>
>> Technically it's legal for geometry shader to not emit any
>> vertices. It's silly, but perfectly legal, so lets make draw
>> stop crashing if it happens.
>>
>> Signed-off-by: Zack Rusin<zackr at vmware.com>
>> ---
>>   src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c     |    9
>> +++++++++
>>   .../auxiliary/draw/draw_pt_fetch_shade_pipeline_llvm.c        |    9
>> +++++++++
>>   2 files changed, 18 insertions(+)
>>
>> diff --git a/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c
>> b/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c
>> index 7b871c2..8d66c88 100644
>> --- a/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c
>> +++ b/src/gallium/auxiliary/draw/draw_pt_fetch_shade_pipeline.c
>> @@ -299,6 +299,15 @@ static void fetch_pipeline_generic( struct
>> draw_pt_middle_end *middle,
>>            }
>>         }
>>      }
>> +   if (prim_info->count == 0) {
>> +      debug_printf("GS/IA didn't emit any vertices!\n");
>
>
> What is "IA"?

Input Assembler I assume.  First part of the DX11 pipeline.

Alex


More information about the mesa-dev mailing list