[Mesa-dev] [PATCH 9/9] glsl: Track existence of default float precision in GLSL ES fragment shaders

Kenneth Graunke kenneth at whitecape.org
Mon Aug 12 15:29:46 PDT 2013


On 08/09/2013 04:38 PM, Ian Romanick wrote:
> From: Ian Romanick <ian.d.romanick at intel.com>
>
> This is required by the spec, and it's a bit tricky because the default
> precision is scoped.  As a result, I'm slightly abusing the symbol
> table.
>
> Fixes piglit no-default-float-precision.frag tests and the piglit
> default-precision-nested-scope-0[1234].frag tests that are currently on
> the piglit mailing list for review.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> Cc: "9.2" <mesa-stable at lists.freedesktop.org>
> ---
>   src/glsl/ast.h          |  4 +++
>   src/glsl/ast_to_hir.cpp | 68 ++++++++++++++++++++++++++++++++++++++++++++++---
>   2 files changed, 68 insertions(+), 4 deletions(-)

Uggghhhhh.  Scoped default precision is really ugly.  But what can you do?

Other than my comments on patch 3, this series is:
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>



More information about the mesa-dev mailing list