[Mesa-dev] [PATCH 08/15] glsl: Add heuristics to print floating-point numbers better.

Matt Turner mattst88 at gmail.com
Fri Aug 23 17:50:25 PDT 2013


On Fri, Aug 23, 2013 at 8:57 AM, Paul Berry <stereotype441 at gmail.com> wrote:
> On 22 August 2013 16:08, Matt Turner <mattst88 at gmail.com> wrote:
> Unfortunately, this patch breaks "make check", because
> src/glsl/tests/optimization-test does a strict character-by-character diff
> between the expected and actual output of optimization passes (I'm not
> thrilled that the optimization tests do this, but off hand I can't think of
> a better way that wouldn't be a pain to implement).
>
> I believe you can fix it by replacing "(0.000000)" with "(0.0)" in all the
> *.expected files in src/glsl/tests/lower_jumps/.
>
> With the "make check" issue fixed, this patch is:
>
> Reviewed-by: Paul Berry <strereotype441 at gmail.com>

Thanks for the heads up. I've folded in this change which fixes make check:

find -name '*.expected' -exec sed -i -e 's/0.000000/0.0/' {} +


More information about the mesa-dev mailing list