[Mesa-dev] [PATCH] i965: Don't flag gather quirks for Gen8+

[Kenneth Graunke]

On 11/29/2013 01:08 AM, Chris Forbes wrote:
> My understanding is that Broadwell retains the same SCS mechanism
> that Haswell has, so even if the underlying issue with this format
> is not fixed, the w/a will be applied in SCS rather than needing
> shader code.
> 
> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
> Cc: Kenneth Graunke <kenneth at whitecape.org>
> ---
>  src/mesa/drivers/dri/i965/brw_wm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/mesa/drivers/dri/i965/brw_wm.c b/src/mesa/drivers/dri/i965/brw_wm.c
> index bc1480c..8a106c7 100644
> --- a/src/mesa/drivers/dri/i965/brw_wm.c
> +++ b/src/mesa/drivers/dri/i965/brw_wm.c
> @@ -352,7 +352,7 @@ brw_populate_sampler_prog_key_data(struct gl_context *ctx,
>  
>           /* gather4's channel select for green from RG32F is broken;
>            * requires a shader w/a on IVB; fixable with just SCS on HSW. */
> -         if (brw->gen >= 7 && !brw->is_haswell && prog->UsesGather) {
> +         if (brw->gen == 7 && !brw->is_haswell && prog->UsesGather) {
>              if (img->InternalFormat == GL_RG32F)
>                 key->gather_channel_quirk_mask |= 1 << s;
>           }
> 

Thanks!  I haven't looked into the Gen8 gather details yet, but you're
definitely right - we'd want to take the Haswell SCS paths.

Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>