[Mesa-dev] [PATCH 3/8] i965: Add a new representation for Broadwell shader instructions.

[Kenneth Graunke]

On 12/10/2013 11:25 PM, Kenneth Graunke wrote:
[snip]
> +static inline void
> +gen8_set_src1_3src_subreg_nr(struct gen8_instruction *inst, unsigned v)
> +{
> +   assert((v & ~0x7) == 0);
> +
> +   gen8_instruction_set_bits(inst, 95, 94, v & 0x3f);
> +   gen8_instruction_set_bits(inst, 96, 96, v >> 2);
> +}

0x3f is craaaaazy...6 bits.  There are only two bits here, so clearly I
want 0x3.  Thankfully, the assertion Eric suggested I add caught this!

I've fixed this locally and will squash the change with this patch
before pushing.

--Ken