[Mesa-dev] [PATCH 17/25] i965/vec4: Obtain atomic counter locations by recursing through the visitor.

Paul Berry stereotype441 at gmail.com
Tue Dec 31 10:54:07 PST 2013


On 2 December 2013 11:39, Francisco Jerez <currojerez at riseup.net> wrote:

> Until now atomic counter built-ins were handled in a way that
> prevented the visitor from encountering atomic counter IR variables
> and dereferences directly.  In the new surface lowering code it's
> going to be more convenient to be able to call back into the visitor
> to let it handle the ugly details of atomic counter array
> dereferences, and it will make sharing the rest of the atomic
> intrinsic handling code easier.
> ---
>  src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 110
> +++++++++++++++----------
>  1 file changed, 65 insertions(+), 45 deletions(-)
>

Both of my comments on patch 16 apply here as well.  With those issues
addressed, this patch is:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20131231/d9aba364/attachment.html>


More information about the mesa-dev mailing list