[Mesa-dev] [PATCH 1/2] vbo: Print display list debug using printf() like dlist.c does.

Jordan Justen jljusten at gmail.com
Fri Feb 1 15:56:51 PST 2013


On Fri, Feb 1, 2013 at 1:34 PM, Eric Anholt <eric at anholt.net> wrote:
> Otherwise, the stderr and stdout debug end up interleaved wrong
> when I pipe them to a file.

Shouldn't we convert dlist.c to _mesa_debug instead? It doesn't seem
right for mesa to use printf...

-Jordan

> ---
>  src/mesa/vbo/vbo_save_api.c |   16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/src/mesa/vbo/vbo_save_api.c b/src/mesa/vbo/vbo_save_api.c
> index b4c90a0..789e864 100644
> --- a/src/mesa/vbo/vbo_save_api.c
> +++ b/src/mesa/vbo/vbo_save_api.c
> @@ -1595,14 +1595,14 @@ vbo_print_vertex_list(struct gl_context *ctx, void *data)
>
>     for (i = 0; i < node->prim_count; i++) {
>        struct _mesa_prim *prim = &node->prim[i];
> -      _mesa_debug(NULL, "   prim %d: %s%s %d..%d %s %s\n",
> -                  i,
> -                  _mesa_lookup_prim_by_nr(prim->mode),
> -                  prim->weak ? " (weak)" : "",
> -                  prim->start,
> -                  prim->start + prim->count,
> -                  (prim->begin) ? "BEGIN" : "(wrap)",
> -                  (prim->end) ? "END" : "(wrap)");
> +      printf("   prim %d: %s%s %d..%d %s %s\n",
> +             i,
> +             _mesa_lookup_prim_by_nr(prim->mode),
> +             prim->weak ? " (weak)" : "",
> +             prim->start,
> +             prim->start + prim->count,
> +             (prim->begin) ? "BEGIN" : "(wrap)",
> +             (prim->end) ? "END" : "(wrap)");
>     }
>  }
>
> --
> 1.7.10.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list