[Mesa-dev] [PATCH 2/4] gallium: add facilities for indirect drawing

Christoph Bumiller e0425955 at student.tuwien.ac.at
Mon Feb 4 03:24:10 PST 2013


On 04.02.2013 08:27, Michel Dänzer wrote:
> On Fre, 2013-02-01 at 22:50 +0100, Christoph Bumiller wrote: 
>> diff --git a/src/gallium/drivers/r300/r300_screen.c b/src/gallium/drivers/r300/r300_screen.c
>> index d0f0070..7ae9dd6 100644
>> --- a/src/gallium/drivers/r300/r300_screen.c
>> +++ b/src/gallium/drivers/r300/r300_screen.c
>> @@ -155,6 +155,7 @@ static int r300_get_param(struct pipe_screen* pscreen, enum pipe_cap param)
>>          case PIPE_CAP_TEXTURE_MULTISAMPLE:
>>          case PIPE_CAP_CUBE_MAP_ARRAY:
>>          case PIPE_CAP_TEXTURE_BUFFER_OBJECTS:
>> +        case PIPE_CAP_DRAW_INDIRECT:
>>              return 0;
>>  
>>          /* SWTCL-only features. */
> Thanks for adding the cap to r300g, but what about r600g and radeonsi?
>

For r300, nv30 and nv50 it was clear that it's not going to be supported.
For sp and lp I just used the helper function because there's probably
no better way to do it there.
For r600 and radeonsi I thought you'd set the cap together with a patch
that implements the feature, there's probably plenty of time until this
has gone through review :)
(Can't tell if it's easy to do or not since I can't find EG+ docs, but
on nvc0 it was rather simple.)
But if no one feels like doing that until indirect drawing can be
merged, I'll add the return 0's for you as well.


More information about the mesa-dev mailing list