[Mesa-dev] [PATCH 2/5] i965: Fix access mode of index buffer rebase.

Eric Anholt eric at anholt.net
Mon Feb 4 19:31:50 PST 2013


It doesn't matter with our current implementation of MapBufferRange,
but it was wrong -- the result pointer is read by intel_upload_data().
---
 src/mesa/drivers/dri/i965/brw_draw_upload.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/mesa/drivers/dri/i965/brw_draw_upload.c b/src/mesa/drivers/dri/i965/brw_draw_upload.c
index e7f45ad..29ec9bb 100644
--- a/src/mesa/drivers/dri/i965/brw_draw_upload.c
+++ b/src/mesa/drivers/dri/i965/brw_draw_upload.c
@@ -811,7 +811,7 @@ static void brw_upload_indices(struct brw_context *brw)
           GLubyte *map = ctx->Driver.MapBufferRange(ctx,
                                                     offset,
                                                     ib_size,
-                                                    GL_MAP_WRITE_BIT,
+                                                    GL_MAP_READ_BIT,
                                                     bufferobj);
 
           intel_upload_data(&brw->intel, map, ib_size, ib_type_size,
-- 
1.7.10.4



More information about the mesa-dev mailing list