[Mesa-dev] [PATCH 1/3] mesa: Restore GL_FOG_COORD_SRC on glPopAttrib(GL_FOG_BIT).

Kenneth Graunke kenneth at whitecape.org
Wed Feb 6 00:28:04 PST 2013


On 02/05/2013 11:09 PM, Kenneth Graunke wrote:
> According to the OpenGL 2.1 specification, Table 6.11 (Coloring),
> GL_FOG_COORD_SRC is supposed to be in the fog attribute.
>
> NOTE: This is a candidate for stable branches.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>   src/mesa/main/attrib.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c
> index a951283..d31bce4 100644
> --- a/src/mesa/main/attrib.c
> +++ b/src/mesa/main/attrib.c
> @@ -1017,6 +1017,7 @@ _mesa_PopAttrib(void)
>                  _mesa_Fogf(GL_FOG_END, fog->End);
>                  _mesa_Fogf(GL_FOG_INDEX, fog->Index);
>                  _mesa_Fogi(GL_FOG_MODE, fog->Mode);
> +               _mesa_Fogi(GL_FOG_COORD_SRC, fog->FogCoordinateSource);
>               }
>               break;
>            case GL_HINT_BIT:

DrNick pointed out that I should probably check 
ctx->Extensions.EXT_fog_coord before calling this.

Alternatively, it looks like all drivers support EXT_fog_coord (all 
Gallium drivers, and classic i915, i965, radeon, r200, nouveau).  So 
maybe it would be better to change the enable flag to dummy_true and 
ignore it here.  Thoughts?  (And can anyone double check in case I 
missed a driver?)


More information about the mesa-dev mailing list