[Mesa-dev] [PATCH] glsl: Initialize all tfeedback_candidate_generator member variables.

Paul Berry stereotype441 at gmail.com
Thu Feb 7 09:26:23 PST 2013


On 5 February 2013 22:59, Vinson Lee <vlee at freedesktop.org> wrote:

> Fixes uninitialized pointer field defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
>

Reviewed-by: Paul Berry <stereotype441 at gmail.com>


> ---
>  src/glsl/link_varyings.cpp | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/glsl/link_varyings.cpp b/src/glsl/link_varyings.cpp
> index e2cb46e..b1317c8 100644
> --- a/src/glsl/link_varyings.cpp
> +++ b/src/glsl/link_varyings.cpp
> @@ -868,7 +868,9 @@ public:
>     tfeedback_candidate_generator(void *mem_ctx,
>                                   hash_table *tfeedback_candidates)
>        : mem_ctx(mem_ctx),
> -        tfeedback_candidates(tfeedback_candidates)
> +        tfeedback_candidates(tfeedback_candidates),
> +        toplevel_var(NULL),
> +        varying_floats(0)
>     {
>     }
>
> --
> 1.8.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130207/a3abbcd2/attachment.html>


More information about the mesa-dev mailing list