[Mesa-dev] [PATCH v2] configure.ac: Do not error out if librt is not available.

Vinson Lee vlee at freedesktop.org
Sat Feb 9 12:34:43 PST 2013


On Sat, Feb 9, 2013 at 11:38 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Fri, Feb 8, 2013 at 7:19 PM, Vinson Lee <vlee at freedesktop.org> wrote:
>> Some platforms, such as Mac OS X, do not have librt.
>
> But Mac OS X (apparently from my quick Google search) doesn't clock_gettime.
>
> clock_gettime is called from two places:
>   src/gallium/auxiliary/os/os_time.c
>   src/mesa/drivers/dri/intel/intel_screen.c
>
> So this patch will just turn configure failures on platforms we do
> care about into build failures. I don't think this is a good idea.
>
> Do we care about either of these pieces of code on Mac OS X? Actually,
> I'm curious why you're doing testing on Mac OS X at all? src/glx/apple
> hasn't even been converted to automake.
>

Would something similar to v1 of this patch be preferred? It avoided
the clock_gettime check only for Mac OS X.

>> Signed-off-by: Vinson Lee <vlee at freedesktop.org>
>> ---
>>  configure.ac | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/configure.ac b/configure.ac
>> index 6735fdc..9b9a0ad 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -500,8 +500,7 @@ AC_CHECK_FUNC([dlopen], [DEFINES="$DEFINES -DHAVE_DLOPEN"],
>>  AC_SUBST([DLOPEN_LIBS])
>>
>>  AC_CHECK_FUNCS([clock_gettime], [CLOCK_LIB=],
>> -               [AC_CHECK_LIB([rt], [clock_gettime], [CLOCK_LIB=-lrt],
>> -                             [AC_MSG_ERROR([Couldn't find clock_gettime])])])
>> +               [AC_CHECK_LIB([rt], [clock_gettime], [CLOCK_LIB=-lrt])])
>>  AC_SUBST([CLOCK_LIB])
>>
>>  dnl See if posix_memalign is available
>> --
>> 1.7.12.4 (Apple Git-37)


More information about the mesa-dev mailing list