[Mesa-dev] [PATCH] CopyTexImage: Don't check sRGB vs LINEAR for desktop GL

Anuj Phogat anuj.phogat at gmail.com
Mon Feb 11 16:50:44 PST 2013


On Mon, Feb 11, 2013 at 3:39 PM, Jordan Justen
<jordan.l.justen at intel.com> wrote:
>
> In OpenGL 4.3, new language was added that would require
> this check. But, if this check results in broken applications
> then perhaps it will be reversed.
>
> For now, remove this check and re-evaluate when
> desktop GL 4.3 is closer.
>
sounds good to me.

> NOTE: This is a candidate for the 9.1 branch.
>
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> Cc: Török Edwin <edwin+ml-mesadev at etorok.net>
> Cc: Ian Romanick <idr at freedesktop.org>
> ---
>  src/mesa/main/teximage.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c
> index 9283ece..db09ace 100644
> --- a/src/mesa/main/teximage.c
> +++ b/src/mesa/main/teximage.c
> @@ -2454,9 +2454,7 @@ copytexture_error_check( struct gl_context *ctx, GLuint dimensions,
>        }
>     }
>
> -   if ((_mesa_is_desktop_gl(ctx) &&
> -        ctx->Extensions.ARB_framebuffer_object) ||
> -       _mesa_is_gles3(ctx)) {
> +   if (_mesa_is_gles3(ctx)) {
>        bool rb_is_srgb = false;
>        bool dst_is_srgb = false;
>
> --
> 1.7.10.4
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the mesa-dev mailing list