[Mesa-dev] [PATCH 2/3] gallivm: fix src modifier fetching with non-float types.

[Roland Scheidegger]

Am 15.02.2013 04:41, schrieb Dave Airlie:
>> From: Roland Scheidegger <sroland at vmware.com>
>>
>> Need to take the type into account. Also, if we want to allow
>> mov's with modifiers we need to pick a type (assume float).
> 
> Just FYI, the r600g hw all ignores modifiers on non-floating types from memory.
It looks like tgsi is underspecced in that area. I can live with other
definitions if there's good reasons for it (I guess I should add docs
stating what is accepted and what not though). FWIW it looks like d3d10
will accept negate modifiers on float and sint instructions (including
the iadd which is both sint and uint not sure if other instructions are
like that - too bad we named it uadd :-)) but not uint ones (granted
negation on unsigned values seems really broken). Absolute modifier is
only allowed on float types however (mov defaulting to float for
modifiers is also a d3d10-ism though I think that makes sense).
I guess for OpenGL it doesn't really make much of a difference either way.

Roland