[Mesa-dev] [PATCH mesa] freedreno: gallium driver for adreno

Dave Airlie airlied at gmail.com
Mon Feb 18 14:38:39 PST 2013


On Tue, Feb 19, 2013 at 4:58 AM, Rob Clark <robdclark at gmail.com> wrote:
> On Mon, Feb 18, 2013 at 12:47 PM, Matt Turner <mattst88 at gmail.com> wrote:
>> On Sun, Feb 17, 2013 at 11:33 AM, Rob Clark <robdclark at gmail.com> wrote:
>>>
>>> diff --git a/src/gallium/drivers/freedreno/Makefile.am b/src/gallium/drivers/freedreno/Makefile.am
>>> new file mode 100644
>>> index 0000000..10abdfb
>>> --- /dev/null
>>> +++ b/src/gallium/drivers/freedreno/Makefile.am
>>> @@ -0,0 +1,35 @@
>>> +include $(top_srcdir)/src/gallium/Automake.inc
>>> +
>>> +noinst_LTLIBRARIES = libfreedreno.la
>>> +
>>> +AM_CFLAGS = \
>>> +       -Werror -Wno-packed-bitfield-compat \
>>> +       -I$(top_srcdir)/src/gallium/include \ <--
>>> +       -I$(top_srcdir)/src/gallium/auxiliary \ <--
>>> +       -I$(top_srcdir)/src/gallium/drivers \
>>> +       -I$(top_srcdir)/include \ <--
>>> +       $(FREEDRENO_CFLAGS) \
>>> +       $(DEFINES) \ <--
>>> +       $(PIC_FLAGS) \
>>> +       $(VISIBILITY_CFLAGS)
>>
>> The <-- mark things that are provided by the GALLIUM_CFLAGS variable
>> in Automake.inc that you've already included. PIC_FLAGS is now dead.
>> Distributions don't like -Werror being hardcoded into upstream's
>> CFLAGS.
>
> Hmm, is there a better way to get -Werror for just freedreno when I am
> building myself?  I do find that it is pretty useful to let the
> compiler help me catch problems rather than debugging them the hard
> way ;-)
>
>
>>> diff --git a/src/gallium/drivers/freedreno/a2xx_reg.h b/src/gallium/drivers/freedreno/a2xx_reg.h
>>> new file mode 100644
>>> index 0000000..27403ec
>>> --- /dev/null
>>> +++ b/src/gallium/drivers/freedreno/a2xx_reg.h
>>> @@ -0,0 +1,455 @@
>>> +/* Copyright (c) 2002,2007-2012, Code Aurora Forum. All rights reserved.
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License version 2 and
>>> + * only version 2 as published by the Free Software Foundation.
>>> + *
>>> + * This program is distributed in the hope that it will be useful,
>>> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
>>> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>>> + * GNU General Public License for more details.
>>
>> GPL?
>
> yeah, this and a couple other headers are coming from qcom kernel
> driver, so it wouldn't be right for me to change the license.  I guess
> I could just re-implement these headers myself.  But IANAL so wasn't
> quite clear about what to do for these..

If they are just lists of #defines (facts) I think they are pretty
much uncopyrightable anyways, so reproduce them under MIT.

But definitely no GPL code can go in mesa or libdrm.

Dave.


More information about the mesa-dev mailing list