[Mesa-dev] [PATCH] glsl: Initialize parcel_out_uniform_storage member variables.

Vinson Lee vlee at freedesktop.org
Mon Feb 18 17:13:09 PST 2013


Fixes uninitialized scalar field defect reported by Coverity.

Signed-off-by: Vinson Lee <vlee at freedesktop.org>
---
 src/glsl/link_uniforms.cpp | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp
index d457e4d..5e391ee 100644
--- a/src/glsl/link_uniforms.cpp
+++ b/src/glsl/link_uniforms.cpp
@@ -263,9 +263,11 @@ public:
    parcel_out_uniform_storage(struct string_to_uint_map *map,
 			      struct gl_uniform_storage *uniforms,
 			      union gl_constant_value *values)
-      : map(map), uniforms(uniforms), next_sampler(0), values(values)
+      : ubo_block_index(0), ubo_byte_offset(0), ubo_row_major(false),
+        map(map) uniforms(uniforms), next_sampler(0), values(values),
+        targets(), shader_samplers_used(0), shader_shadow_samplers(0)
    {
-      memset(this->targets, 0, sizeof(this->targets));
+      /* empty */
    }
 
    void start_shader()
-- 
1.8.1.2



More information about the mesa-dev mailing list