[Mesa-dev] [PATCH] i965/gen[45]: Do point coord logic whenever gl_PointCoord is asked for.

Eric Anholt eric at anholt.net
Thu Feb 21 08:48:14 PST 2013


Ian Romanick <idr at freedesktop.org> writes:

> On 02/15/2013 10:46 PM, Eric Anholt wrote:
>> The desktop spec asks for gl_PointCoord to be defined only when
>> GL_POINT_SPRITE is enabled, and it's undefined otherwise (why?!).  The
>> ES spec doesn't have GL_POINT_SPRITE and gl_PointCoord is always
>> defined.  So just make our implementation always give you gl_PointCoord
>> regardless of the enable.
>
> We had a similar issue with core-profiles, which also lack the enable. 
> I seem to recall that we just changed the default state to enabled... 
> which would also fix this issue for i915.  Right?

Yeah, sent out a patch fixing the regression.  I'm tempted to put this
patch in anyway -- it gets us consistency with gen6+, and keeps you from
having to think about what happens in the undefined case before.
Thoughts?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130221/42e46f0e/attachment.pgp>


More information about the mesa-dev mailing list