[Mesa-dev] [PATCH] i965: Avoid segfault in gen6_upload_state

Carl Worth cworth at cworth.org
Fri Feb 22 17:15:29 PST 2013


Ian Romanick <idr at freedesktop.org> writes:
> Also, the correct way to say this is:
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=59445

Thanks. I missed that on this patch, but will get it right in the
future.

>> ctx->DrawBuffer->Visual doesn't know about your alpha bits when you have
>> MRT some with alpha and some without.  I prefer the first patch, which
>> would get my:
>
> That makes sense.  The probably means the other place that uses 
> ctx->DrawBuffer->Visual should get changed too.

I went to make that change, but there's no loop over draw buffers in
brw_cc.c. Presumably there's not support for MRT on that generation of
hardware?

So I think we may be fine as-is here.

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130222/bcd6e5ab/attachment.pgp>


More information about the mesa-dev mailing list