[Mesa-dev] [PATCH] radeonsi: Fix memory leak in si_set_constant_buffer.

Alex Deucher alexdeucher at gmail.com
Sun Feb 24 08:12:35 PST 2013


On Sat, Feb 23, 2013 at 8:27 PM, Vinson Lee <vlee at freedesktop.org> wrote:
> Fixes resource leak defect reported by Coverity.
>
> Signed-off-by: Vinson Lee <vlee at freedesktop.org>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  src/gallium/drivers/radeonsi/si_state.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/radeonsi/si_state.c b/src/gallium/drivers/radeonsi/si_state.c
> index 769ba0c..a395ec4 100644
> --- a/src/gallium/drivers/radeonsi/si_state.c
> +++ b/src/gallium/drivers/radeonsi/si_state.c
> @@ -2523,6 +2523,7 @@ static void si_set_constant_buffer(struct pipe_context *ctx, uint shader, uint i
>
>         default:
>                 R600_ERR("unsupported %d\n", shader);
> +               FREE(pm4);
>         }
>
>         if (cb->buffer != &rbuffer->b.b)
> --
> 1.8.1.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list