[Mesa-dev] [PATCH V4 00/19] ARB_texture_multisample support

Ian Romanick idr at freedesktop.org
Tue Feb 26 08:09:07 PST 2013


On 02/26/2013 02:10 AM, Chris Forbes wrote:
> This series adds the core mesa bits for ARB_texture_multisample, and support
> in the i965 driver for Gen6 and Gen7.
>
> I've addressed the issues that were raised for V3, and also fixed some other
> bugs which I found while beefing up the piglit coverage for this.
>
> - Proxy texture targets were denied in glTexImage*Multisample.
> - I was lying to the i965 fs regalloc about how many regs were written by
>     the sampler message, so it was clobbering the results in nontrivial shaders.
>
> Things for another day:
> - CMS layout support on Gen7.
> - Verify multisample depth arrays. Until this is done, we only advertise
>     MAX_DEPTH_TEXTURE_SAMPLES=1.
>
> A follow-up series addresses the interactions between this extension, classic
> multisample renderbuffer creation, and internalformat_query, which resolves the
> remaining TODO in 12/19.

I'm pretty stoked to see this code land. :)

Patches 1 through 9 and 11 are

Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>

I don't know the material of patch 10 well enough to give a R-b, but 
Paul's opinion is good enough for me.  Call that

Acked-by: Ian Romanick <ian.d.romanick at intel.com>

I sent a minor comment / question about 12.

For the rest, I'll defer to people more familiar with the driver back-end.

> -- Chris
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev



More information about the mesa-dev mailing list