[Mesa-dev] [PATCH V4 11/19] mesa: support multisample textures in framebuffer completeness check

Eric Anholt eric at anholt.net
Thu Feb 28 14:55:16 PST 2013


Chris Forbes <chrisf at ijw.co.nz> writes:

> - sample count must be the same on all attachments
> - fixedsamplepositions must be the same on all attachments
> (renderbuffers have fixedsamplepositions=true implicitly; only
> multisample textures can choose to have it false)
>
> V2: - fix wrapping to 80 columns, debug message, fix for state moving
>       from texobj to image.
>     - stencil texturing tweaks tidied up and folded in here.
>
> V3: - Removed silly stencil hacks entirely; the extension doesn't
>       actually make stencil-only textures legal at all.
>     - Moved sample count / fixed sample locations checks into
>       existing attachment-type-specific blocks, as suggested by Eric
>
> V4: - Removed stencil hacks which were missed in V3 (thanks Eric)
>     - Don't move the declaration of texImg; only required pre-V3.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130228/d8dfe8d4/attachment.pgp>


More information about the mesa-dev mailing list