[Mesa-dev] [PATCH] mesa: Print more informative debug for _mesa_do_init_remap_table().

Kenneth Graunke kenneth at whitecape.org
Thu Jan 24 03:32:37 PST 2013


On 01/10/2013 01:35 PM, Eric Anholt wrote:
> This is the same logic from _mesa_map_function_array().
> ---
>   src/mesa/main/remap.c |    6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/main/remap.c b/src/mesa/main/remap.c
> index c89fba4..a098705 100644
> --- a/src/mesa/main/remap.c
> +++ b/src/mesa/main/remap.c
> @@ -208,8 +208,10 @@ _mesa_do_init_remap_table(const char *pool,
>         offset = _mesa_map_function_spec(spec);
>         /* store the dispatch offset in the remap table */
>         driDispatchRemapTable[i] = offset;
> -      if (offset < 0)
> -         _mesa_warning(NULL, "failed to remap index %d", i);
> +      if (offset < 0) {
> +         const char *name = spec + strlen(spec) + 1;
> +         _mesa_warning(NULL, "failed to remap %s", name);
> +      }
>      }
>   }

Looks good to me.
Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>


More information about the mesa-dev mailing list