[Mesa-dev] [PATCH v2] i965: Implement CopyTexSubImage2D via BLORP (and use it by default).

[Carl Worth]

Kenneth Graunke <kenneth at whitecape.org> writes:
> I didn't want to add dead code, so I felt obliged to use the new method 
> somewhere in the order.  Putting it below meta doesn't make much 
> sense---hardware paths below software paths?  I could put it below BLT 
> and move it to #1 in the next commit, but...that's still a change in the 
> behavior.  It's not clear to me that it's better.
>
> How would you prefer it split?

For me, the most annoyance I've had with commits doing too much at once
comes later. Too common flavors are:

1. I bisect, but instead of finding one small commit making one change,
   the bisect lands on a giant change-the-world commit, giving very
   little bisect. (And for bonus nuisance, multiple bugs keep bisecting
   down to this same change-the-world commit.)

   Obviously, this patch isn't in that category.

2. I want to revert a change, but "git revert" isn't useful since the
   change of interest is tangled with other things.

   And maybe this second case isn't likely to happen in this case, (I
   imagine it's unlikely that other users of this function will show
   up?).

It's clear you've thought through this. So your call if there's no easy
way to split this:

>> Reviewed-by: Carl Worth <cworth at cworth.org>

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130129/d1d72d39/attachment.pgp>