[Mesa-dev] [PATCH] Renamed functions for file enums.c

Eric Anholt eric at anholt.net
Wed Jun 5 10:13:06 PDT 2013


Brian Paul <brianp at vmware.com> writes:

> On 06/05/2013 03:53 AM, Arnas Milasevicius wrote:
>>
>> diff --git a/src/mapi/glapi/gen/gl_enums.py b/src/mapi/glapi/gen/gl_enums.py
>> index 806d384..ba19196 100644
>> --- a/src/mapi/glapi/gen/gl_enums.py
>> +++ b/src/mapi/glapi/gen/gl_enums.py
>> @@ -91,7 +91,7 @@ static int compar_nr( const int *a, const unsigned *b )
>>
>>   static char token_tmp[20];
>>
>> -const char *_mesa_lookup_enum_by_nr( int nr )
>> +const char *_mesa_enum_nr( int nr )
>
> I don't think this is a good name for the function.  I'd suggest 
> _mesa_enum_string() since we're returning the string for the given enum 
> value, not a number.

_mesa_get_enum_name() to match _mesa_get_format_name()?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130605/54d971f2/attachment.pgp>


More information about the mesa-dev mailing list