[Mesa-dev] [PATCH 04/14] gallium: Document packed formats

[Michel Dänzer]

On Die, 2013-06-18 at 13:28 -0400, Adam Jackson wrote:
> Signed-off-by: Adam Jackson <ajax at redhat.com>
> ---
>  src/gallium/docs/format.rst | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/docs/format.rst b/src/gallium/docs/format.rst
> index 2514656..e270d93 100644
> --- a/src/gallium/docs/format.rst
> +++ b/src/gallium/docs/format.rst
> @@ -6,7 +6,14 @@ Gallium format names mostly follow D3D10 conventions, with some extensions.
>  Format names like XnYnZnWn have the X component in the lowest-address n bits
>  and the W component in the highest-address n bits; for B8G8R8A8, byte 0 is
>  blue and byte 3 is alpha.  Note that platform endianness is not considered
> -in this definition.
> +in this definition.  In C:
> +
> +    struct xyzw8888 { uint8_t x, y, z, w; };

It seems a tad confusing to call this xyzw8888, as opposed to x8y8z8w8.


Other than that, the series looks good to me.


-- 
Earthling Michel Dänzer           |                   http://www.amd.com
Libre software enthusiast         |          Debian, X and DRI developer