[Mesa-dev] [PATCH] tgsi_exec: Fix mask calculation for emit_kill_if.

Roland Scheidegger sroland at vmware.com
Wed Nov 20 09:35:48 PST 2013


On 11/20/2013 05:32 PM, jfonseca at vmware.com wrote:
> From: José Fonseca <jfonseca at vmware.com>
>
> Same as Si Chen's commit e7a5905d8a3960b0981750f8131e3af9acbfcdb8 for
> tgsi_exec module.
>
> Not actually tested, because softpipe is failing the test that caught
> this bug due to unrelated issues.
> ---
>   src/gallium/auxiliary/tgsi/tgsi_exec.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
> index 6db1238..b614907 100644
> --- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
> +++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
> @@ -1610,6 +1610,9 @@ exec_kill_if(struct tgsi_exec_machine *mach,
>               kilmask |= 1 << i;
>      }
>
> +   /* restrict to fragments currently executing */
> +   kilmask &= mach->ExecMask;
> +
>      mach->Temps[TEMP_KILMASK_I].xyzw[TEMP_KILMASK_C].u[0] |= kilmask;
>   }

Reviewed-by: Roland Scheidegger <sroland at vmware.com>


More information about the mesa-dev mailing list