[Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

[Emil Velikov]

On 07/10/13 18:53, Emil Velikov wrote:
> On 07/10/13 16:48, Tom Stellard wrote:
>> On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote:
>>> Use PKG_CHECK_MODULE over requesting the user to setup the
>>> option at configure time. Drop unused EXPAT_INCLUDE and add
>>> EXPAT_CFLAGS to all classic/dri and gallium/dri targets.
>>>
>>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>>> ---
[...]
>>
>> Is it possible to get the same behavior as the --with-expat option by
>> setting EXPAT_* environment variables at configure time?  If so, it would
>> be nice to add a note to the commit message explaining how to do this.
>>
> Very nice point Tom.
> No, it cannot in it's current form. My intent was so standardise
> handling of mesa dependencies. That means it will break on certain
> (hacky) setups, where expat is available without expat.pc or when they
> are linking against system libdrm, libudev, etc. and custom expat. It's
> a all or nothing solution.
> 
> From my POV the solution for those people would be have an enviroment
> where all the libraries are present (coordinated) in a single location
> (available to pkg-config via PKG_CONFIG_PATH).
> 
> FWIW Archlinux, Gentoo, Fedora, OpenSUSE and Debian do not use the flag.
> 
> Sorry for the lengthy explanation.
> 
Hi Tom,

I believe that this is not the answer you were hoping for, nor the one I
wanted to give.

With that said if you have any objections feel free to drop the patch,
as long as the rest of the series still lives :)

The whole annotated and rebased series is available in the
xorg-cleanups-v2 branch at https://github.com/evelikov/Mesa.git

~Emil

> Cheers
> Emil
> 
>> -Tom
>>>