[Mesa-dev] [PATCH 17/17] glsl: Remove glsl_parser_state MaxVaryingFloats field

[Paul Berry]

On 10 September 2013 12:11, Ian Romanick <idr at freedesktop.org> wrote:

> From: Ian Romanick <ian.d.romanick at intel.com>
>
> It is no longer used anywhere.
>
> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> ---
>  src/glsl/glsl_parser_extras.cpp | 1 -
>  src/glsl/glsl_parser_extras.h   | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/src/glsl/glsl_parser_extras.cpp
> b/src/glsl/glsl_parser_extras.cpp
> index 1e4d7c7..ca0b620 100644
> --- a/src/glsl/glsl_parser_extras.cpp
> +++ b/src/glsl/glsl_parser_extras.cpp
> @@ -95,7 +95,6 @@ _mesa_glsl_parse_state::_mesa_glsl_parse_state(struct
> gl_context *_ctx,
>     this->Const.MaxTextureCoords = ctx->Const.MaxTextureCoordUnits;
>     this->Const.MaxVertexAttribs = ctx->Const.VertexProgram.MaxAttribs;
>     this->Const.MaxVertexUniformComponents =
> ctx->Const.VertexProgram.MaxUniformComponents;
> -   this->Const.MaxVaryingFloats = ctx->Const.MaxVarying * 4;
>     this->Const.MaxVertexTextureImageUnits =
> ctx->Const.VertexProgram.MaxTextureImageUnits;
>     this->Const.MaxCombinedTextureImageUnits =
> ctx->Const.MaxCombinedTextureImageUnits;
>     this->Const.MaxTextureImageUnits =
> ctx->Const.FragmentProgram.MaxTextureImageUnits;
> diff --git a/src/glsl/glsl_parser_extras.h b/src/glsl/glsl_parser_extras.h
> index 15abbbc..883527a 100644
> --- a/src/glsl/glsl_parser_extras.h
> +++ b/src/glsl/glsl_parser_extras.h
> @@ -213,7 +213,6 @@ struct _mesa_glsl_parse_state {
>        unsigned MaxTextureCoords;
>        unsigned MaxVertexAttribs;
>        unsigned MaxVertexUniformComponents;
> -      unsigned MaxVaryingFloats;
>        unsigned MaxVertexTextureImageUnits;
>        unsigned MaxCombinedTextureImageUnits;
>        unsigned MaxTextureImageUnits;
> --
> 1.8.1.4



I sent comments on patches 3, 9, and 11.  With Brian Paul's suggested fix
to patch 16, the remainder are:

Reviewed-by: Paul Berry <stereotype441 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130911/9f57a89c/attachment.html>