[Mesa-dev] [PATCH] android: Remove builtin_compiler

Chad Versace chad.versace at linux.intel.com
Wed Sep 18 09:36:38 PDT 2013


On 09/13/2013 07:15 AM, Adrian M Negreanu wrote:
> On Fri, Sep 13, 2013 at 5:01 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> Getting rid of the builtin_compiler from the Android build is a good
>> idea... but I'll let Chad or someone who knows /anything/ about the
>> Android build system actually review the patch.
>>
>> Acked-by: Ian Romanick <ian.d.romanick at intel.com>
>>
>> I don't think I want to remove any of the other bits of the builtin
>> compiler or standalone compiler.  I've been working on resurrecting the
>> standalone compiler for use as a developer tool.
>>
>> http://cgit.freedesktop.org/~idr/mesa/log/?h=standalone-compiler
>>
>
> (add Chad to cc:)
> The parts removed from Android.gen.mk were using generate_builtins.py,
> which was also removed; that will trigger a compile failure.

This patch looks correct to me, though I didn't test it.
Reviewed-by: Chad Versace <chad.versace at linux.intel.com>
I'll commit it now.



More information about the mesa-dev mailing list