[Mesa-dev] [PATCH 10/24] glsl: Implement parser support for atomic counters.

Francisco Jerez currojerez at riseup.net
Wed Sep 18 12:35:36 PDT 2013


Ian Romanick <idr at freedesktop.org> writes:

> On 09/15/2013 02:10 AM, Francisco Jerez wrote:
>>[...]
>>  
>>  
>> +#include <map>
>> +#include <set>
>
> No.  We are not using STL or templates.
>

Any reason for it to be still so?

Actually I started implementing this patch using one of mesa's hash
tables, but at some point I realized I was cluttering the code with
pointer casts, awkward syntax and memory management code spread over
several different places around _mesa_glsl_parse_state.  I'm fine either
way, really, I can revert to my earlier code if you really want -- It's
just not going to be especially fun for whoever gets to maintain it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20130918/57da0f7c/attachment.pgp>


More information about the mesa-dev mailing list