[Mesa-dev] [PATCH] llvmpipe: we need to subdivide if fb is bigger in either direction

[Jose Fonseca]

----- Original Message -----
> Am 24.09.2013 22:26, schrieb Zack Rusin:
> > We need to subdivide triangles if either of the dimensions is
> > larger than the max edge length, not when both of them are larger.
> > 
> > Signed-off-by: Zack Rusin <zackr at vmware.com>
> > ---
> >  src/gallium/drivers/llvmpipe/lp_setup.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/gallium/drivers/llvmpipe/lp_setup.c
> > b/src/gallium/drivers/llvmpipe/lp_setup.c
> > index 5fde01f..c8199b4 100644
> > --- a/src/gallium/drivers/llvmpipe/lp_setup.c
> > +++ b/src/gallium/drivers/llvmpipe/lp_setup.c
> > @@ -1015,7 +1015,7 @@ try_update_scene_state( struct lp_setup_context
> > *setup )
> >         * To cope with this problem we check if triangles are large and
> >         * subdivide them if needed.
> >         */
> > -      setup->subdivide_large_triangles = (setup->fb.width > 2048 &&
> > +      setup->subdivide_large_triangles = (setup->fb.width > 2048 ||
> >                                            setup->fb.height > 2048);
> >     }
> >                                        
> > 
> 
> LGTM.

Same here.

Jose