[Mesa-dev] [PATCH 1/3] gallium: Add PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY

Francisco Jerez currojerez at riseup.net
Fri Apr 18 03:08:03 PDT 2014


Bruno Jiménez <brunojimen at gmail.com> writes:

> From: Tom Stellard <thomas.stellard at amd.com>
>
> ---
>  src/gallium/include/pipe/p_defines.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/gallium/include/pipe/p_defines.h b/src/gallium/include/pipe/p_defines.h
> index a3a1ae1..93f9642 100644
> --- a/src/gallium/include/pipe/p_defines.h
> +++ b/src/gallium/include/pipe/p_defines.h
> @@ -641,7 +641,8 @@ enum pipe_compute_cap
>     PIPE_COMPUTE_CAP_MAX_LOCAL_SIZE,
>     PIPE_COMPUTE_CAP_MAX_PRIVATE_SIZE,
>     PIPE_COMPUTE_CAP_MAX_INPUT_SIZE,
> -   PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE
> +   PIPE_COMPUTE_CAP_MAX_MEM_ALLOC_SIZE,
> +   PIPE_COMPUTE_CAP_MAX_CLOCK_FREQUENCY,

You should also update the docs (src/gallium/docs/source/screen.rst)
with a short description of the new compute cap -- specifically, in
which unit is the clock frequency expressed.  Wouldn't it make more
sense to express it in MHz as it was in the original patch series so it
matches what OpenCL expects?

>  };
>  
>  /**
> -- 
> 1.9.2
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140418/bc1a979b/attachment.sig>


More information about the mesa-dev mailing list