[Mesa-dev] [PATCH] swrast: Add glBlitFramebuffer to commands affected by conditional rendering

Carl Worth cworth at cworth.org
Wed Apr 23 00:24:09 PDT 2014


Anuj Phogat <anuj.phogat at gmail.com> writes:
> +   /* Page 679 of OpenGL 4.4 spec says:
> +    *    "Added BlitFramebuffer to commands affected by conditional rendering in
> +    *     section 10.10 (Bug 9562)."
> +    */
> +   if (!_mesa_check_conditional_render(ctx))
> +      return; /* Do not blit */
> +
>     if (!_mesa_clip_blit(ctx, &srcX0, &srcY0, &srcX1, &srcY1,
>                          &dstX0, &dstY0, &dstX1, &dstY1)) {
>        return;

After I picked this to the 10.1 branch and tested I found the following
piglit regression:

	$ ~/src/piglit/bin/nv_conditional_render-blitframebuffer -auto 
	Probe color at (0,16)
	  Expected: 0.000000 1.000000 0.000000 0.000000
	  Observed: 1.000000 0.000000 0.000000 0.000000
	PIGLIT: {'result': 'fail' }

So I'm moving this patch off of the "applied" queue and onto a new
"rejected" queue as can be seen here:

	http://cworth.org/~cworth/mesa-stable-queue/

Feel free to follow up with any additional information that would be
useful, (such as an updated patch or a change to the relevant piglit
test).

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140423/a575ae29/attachment.sig>


More information about the mesa-dev mailing list