[Mesa-dev] [PATCH 04/11] i965/blorp: Put sampler index in src1 of texture ops

Chris Forbes chrisf at ijw.co.nz
Wed Aug 6 14:07:09 PDT 2014


OK, assuming no one complains, I'll push the series later today.

On Thu, Aug 7, 2014 at 8:44 AM, Ian Romanick <idr at freedesktop.org> wrote:
> On 08/06/2014 12:40 PM, Chris Forbes wrote:
>> Yes -- there's no interaction between patches 3 and 4. Blorp only
>> shares the generator.
>
> Okay.  Then these two are also
>
> Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
>
>> On Tue, Aug 5, 2014 at 1:32 PM, Ian Romanick <idr at freedesktop.org> wrote:
>>> Does it still build with patch 3 without patch 4?
>>>
>>> On 08/04/2014 01:58 AM, Chris Forbes wrote:
>>>> Signed-off-by: Chris Forbes <chrisf at ijw.co.nz>
>>>> ---
>>>>  src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 3 ++-
>>>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp
>>>> index c1676a9..7d4b327 100644
>>>> --- a/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp
>>>> +++ b/src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp
>>>> @@ -78,7 +78,8 @@ brw_blorp_eu_emitter::emit_texture_lookup(const struct brw_reg &dst,
>>>>                                            unsigned base_mrf,
>>>>                                            unsigned msg_length)
>>>>  {
>>>> -   fs_inst *inst = new (mem_ctx) fs_inst(op, dst, brw_message_reg(base_mrf));
>>>> +   fs_inst *inst = new (mem_ctx) fs_inst(op, dst, brw_message_reg(base_mrf),
>>>> +                                         fs_reg(0u));
>>>>
>>>>     inst->base_mrf = base_mrf;
>>>>     inst->mlen = msg_length;
>>>>
>>>
>>
>


More information about the mesa-dev mailing list