[Mesa-dev] [PATCH] r600g: Fix flat/smooth shade state toggle

[Marek Olšák]

The flag is only used to set S_028644_FLAT_SHADE on all r600g chips. I
don't see it being used by the shader code generation.

Marek

On Wed, Aug 20, 2014 at 8:50 PM, Glenn Kennard <glenn.kennard at gmail.com> wrote:
> On Wed, 20 Aug 2014 20:16:50 +0200, Marek Olšák <maraeo at gmail.com> wrote:
>
>> Generally, only states which need a full shader compilation must be in
>> the shader key. Flatshade is not one of them, because it only causes
>> register updates, so this is not a proper solution. Or I am missing
>> something?
>>
>> Marek
>>
>
> Evergreen/Cayman need to recompile the shader since the interpolation is
> done using either INTERP_XY instruction for smooth or INTERP_LOAD_P0 for
> flat. R600-R700 technically don't need to, but the prior code already does
> anyway since flat/smooth register setup is done from output values computed
> when compiling the shader.
>
>
> /Glenn