[Mesa-dev] [PATCH 1/2] i965/fs: Remove FS_OPCODE_BLORP_FB_WRITE.

Matt Turner mattst88 at gmail.com
Thu Aug 28 13:50:39 PDT 2014


On Tue, Aug 12, 2014 at 9:48 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> index d3509a0..19f7ef8 100644
> --- a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
> @@ -186,7 +186,7 @@ fs_generator::generate_fb_write(fs_inst *inst)
>                    brw_imm_ud(0x1 << 11));
>           }
>
> -        if (inst->target > 0) {
> +        if (fp && inst->target > 0) {
>             /* Set the render target index for choosing BLEND_STATE. */
>             brw_MOV(p, retype(brw_vec1_reg(BRW_MESSAGE_REGISTER_FILE,
>                                            inst->base_mrf, 2),

I don't understand this change. I don't see fp being used elsewhere in
this patch.

Patch 2 is

Reviewed-by: Matt Turner <mattst88 at gmail.com>

and so is this one once this hunk is sorted out.


More information about the mesa-dev mailing list