[Mesa-dev] [PATCH 1/1] r600, llvm: Fix mem leak

Aaron Watry awatry at gmail.com
Mon Dec 1 17:18:20 PST 2014


I like it, but one thing I'd like to request... Can you check to make
sure that radeon_shader_binary.global_symbol_offsets isn't also
leaked? If so, let's fix that as well.

If that's not getting leaked, then it looks good to me.

--Aaron

On Mon, Dec 1, 2014 at 5:33 PM, Jan Vesely <jan.vesely at rutgers.edu> wrote:
> ping
>
> On Mon, 2014-11-03 at 20:29 -0500, Jan Vesely wrote:
>> Signed-off-by: Jan Vesely <jan.vesely at rutgers.edu>
>> ---
>>  src/gallium/drivers/r600/r600_llvm.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c
>> index c19693a..5f74bf7 100644
>> --- a/src/gallium/drivers/r600/r600_llvm.c
>> +++ b/src/gallium/drivers/r600/r600_llvm.c
>> @@ -888,6 +888,7 @@ unsigned r600_llvm_compile(
>>
>>       FREE(binary.code);
>>       FREE(binary.config);
>> +     FREE(binary.rodata);
>>
>>       return r;
>>  }
>
> --
> Jan Vesely <jan.vesely at rutgers.edu>
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>


More information about the mesa-dev mailing list