[Mesa-dev] [PATCH] i965/fs: Don't offset uniform registers in half().

Matt Turner mattst88 at gmail.com
Tue Dec 2 22:15:06 PST 2014


On Tue, Dec 2, 2014 at 10:11 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
>
> On Dec 2, 2014 9:19 PM, "Matt Turner" <mattst88 at gmail.com> wrote:
>>
>> Half gives you the second half of a SIMD16 register, but if the register
>> is a uniform it would incorrectly give you the next register.
>
> I'm curious as to where this came up. To my knowledge, the only time that's
> used, we know it's not a uniform.  Am I missing something?
>
> In any case, that seems like the right way to handle uniforms. We could also
> do that for immediates.
>
> Assuming it has a point,
> Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

Yeah, once we implement integer multiplication in SIMD16 we'll hit
this. I sent the patches a few months ago, and Ben's incorporating
them into a larger series that should be out soon.


More information about the mesa-dev mailing list