[Mesa-dev] [PATCH 1/3] glsl: Add convenience function get_sampler_instance

[Carl Worth]

On Thu, Dec 04 2014, Ian Romanick wrote:
> Shouldn't type be glsl_base_type instead of unsigned?

Yes, thanks for the catch. Fixed.

>> +         if (shadow)
>> +            return (array ? sampler2DArrayShadow_type : sampler2DShadow_type
>> +);
>
> It's weird that the closing paren ended up here.  I don't think the
> parens are necessary, so maybe drop them?

This was just a stray newline, not wrapping or anything. Thanks for
catching it.

I agree that the parentheses aren't required, but they are idiomatic
with all of the surrounding code. So I'll leave them for now.

-Carl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141204/e74f2da1/attachment.sig>