[Mesa-dev] [PATCH 1/3] glsl: Add convenience function get_sampler_instance

Carl Worth cworth at cworth.org
Thu Dec 4 19:22:49 PST 2014


On Thu, Dec 04 2014, Matt Turner wrote:
> On Thu, Dec 4, 2014 at 2:00 PM, Carl Worth <cworth at cworth.org> wrote:
>> +   assert(!"Should not get here.");
>> +   return error_type;
>
> Let's just use unreachable("not reached") here.

That's a good idea. I copied this line from the surrounding code in the
same file, (there are about 6 or 7 other instances in this file). So I
think I'll follow up with a separate patch to clean these up. Should I
pass over the whole source tree? Or would a change like that be too
annoying for outstanding patches, etc.?

-Carl

-- 
carl.d.worth at intel.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20141204/920b5bf4/attachment.sig>


More information about the mesa-dev mailing list