[Mesa-dev] [PATCH] centroid affects interpolation

[Rogovin, Kevin]

Hi,

Without my patch, mesa fails to compile:

#version 300 es
centroid in mediump vec2 centr;

gives the error message "error: no precision specified this scope for type `vec2' "

You are both correct, and I was wrong, making centroid an interpolation qualifier; the correct solution is to tweak the rule for type_qualifier; it looks like the rule for type_qualifier is the one that needs tweaking to get this right; 

Would you like me to do that one, or will one of you like to kill that bug?

-Kevin






________________________________________
From: Kenneth Graunke [kenneth at whitecape.org]
Sent: Wednesday, February 05, 2014 6:02 AM
To: Rogovin, Kevin; mesa-dev at lists.freedesktop.org
Subject: Re: [Mesa-dev] [PATCH] centroid affects interpolation

On 02/04/2014 05:01 AM, Kevin Rogovin wrote:
> Place centroid keyword as an interpolation qualifier.
> Previously was a storage qualifier. Fixes front end
> to accept input of the form "centroid in type variable"

No, it doesn't.  Without your patch, Mesa successfully compiles the
following shader:

#version 130
centroid in float foo;

which is of the form "centroid in type variable".  Chris is right - the
specs are very clear that 'centroid in' was a storage qualifier, and if
420pack is enabled, 'centroid' becomes an auxiliary storage qualifier.