[Mesa-dev] [PATCH 3/3] glx/apple: Fixed glx context memory leak in case of failure.

Jeremy Huddleston Sequoia jeremyhu at apple.com
Mon Feb 10 12:18:31 PST 2014


Yep, looks right to me.

Reviewed-by: Jeremy Huddleston Sequoia: <jeremyhu at apple.com>

On Feb 10, 2014, at 07:57, Ian Romanick <idr at freedesktop.org> wrote:

> Perhaps Jeremy can review this patch...
> 
> On 02/10/2014 01:58 AM, Siavash Eliasi wrote:
>> ---
>> src/glx/apple/apple_glx_context.c | 1 +
>> 1 file changed, 1 insertion(+)
>> 
>> diff --git a/src/glx/apple/apple_glx_context.c b/src/glx/apple/apple_glx_context.c
>> index 0bb25b4..8a6ded2 100644
>> --- a/src/glx/apple/apple_glx_context.c
>> +++ b/src/glx/apple/apple_glx_context.c
>> @@ -142,6 +142,7 @@ apple_glx_create_context(void **ptr, Display * dpy, int screen,
>>    if (sharedac && !is_context_valid(sharedac)) {
>>       *errorptr = GLXBadContext;
>>       *x11errorptr = false;
>> +      free(ac);
>>       return true;
>>    }
>> 
>> 
> 



More information about the mesa-dev mailing list