[Mesa-dev] [PATCH 1/2] vl: add motion adaptive deinterlacer

[Andy Furniss]

Andy Furniss wrote:
> Ilia Mirkin wrote:
>> On Sat, Feb 15, 2014 at 5:10 AM, Christian König
>> <deathsimple at vodafone.de> wrote:
>>> That's most likely an issue with st/vdpau. I implemented a small
>>> hack to clear the black bars of a surface only once. No idea how
>>> exactly it happens, but Grigoris patch seems to somehow break the
>>> logic there.
>>>
>>> Anyway we need to rework this part when getting DRI3 anyway (much
>>> more efficiently and cleanly), so I'm not sure if we should
>>> bother fixing it.
>>
>> OK. Well, until then, the deinterlacing filter is largely unusable
>> -- you end up with flickering textures in the bars (I guess each
>> frame extends all the way out, and they end up with different junk
>> data). Which is a shame, since the filter works really well. But at
>> the same time I'm not volunteering to figure out what's going on
>> :)
>
> Can't reproduce that on my rv790 testing with recentish svn mplayer.
>
> Tried 4/3 -> 16/9 fullscreen side bars are black.
>
> Tried forcing -aspect 2.85 on 16/9 source again top/bottom bars are
> black.

I should also add -

Thanks Grigori for doing this - looks really good on HD stuff I've
tested and of course is easily fast enough, unlike anything on the CPU
at high res.

Any plans for the future?

Pre-filtered bicubic HQ scaling would be nice :-)

Below not specific to the deinterlacer, but I would be interested if
others see these as my card is not UVD so I have to patch to get the
deinterlacer to work - I know this breaks decode, but that's no problem
for me.

So I set  PIPE_VIDEO_CAP_PREFERS_INTERLACED
PIPE_VIDEO_CAP_SUPPORTS_INTERLACED to true.

I saw in the code comment that 422 isn't supported, so tested - roughly
works but can have issues depending on source - but unsupported is not
the issue.

I noticed that the weave shader also has issues with 422 - I didn't
expect this as using the progressive (for me unpatched mesa) looks OK -
so is 422 supposed to be supported by weave?

At the start or when I press f on mplayer to toggle between full/window
I see a frame of old/uninitialised video mem - does this happen on nvidia?

TIA

Andy.