[Mesa-dev] [PATCH 04/10] egl: Unhide functionality in _eglInitSync()

Juha-Pekka Heikkilä juhapekka.heikkila at gmail.com
Tue Feb 18 01:02:11 PST 2014


On Tue, Feb 18, 2014 at 9:40 AM, Chia-I Wu <olvaffe at gmail.com> wrote:
> On Tue, Feb 18, 2014 at 12:21 AM, Juha-Pekka Heikkila
> <juhapekka.heikkila at gmail.com> wrote:
>> _eglInitResource() was used to memset entire _EGLSync by
>> writing more than size of pointed target. This does work
>> as long as Resource is the first element in _EGLSync,
>> this patch fixes such dependency.
> _EGLSync is a subclass of _EGLResource so the dependency always holds.
>  _eglInitResource is made to be able to initialize any class derived
> from _EGLResource, by requiring the size of the derived class to be
> specified.
>

ah, ok. I of course saw the intention but did not notice comment about
it. Maybe you could consider reverting these two:

498d10e egl: Unhide functionality in _eglInitSurface()
1456ed8 egl: Unhide functionality in _eglInitContext()

They do the same for _EGLSurface and _EGLContext as I was doing here
for _EGLSync.

/Juha-Pekka


More information about the mesa-dev mailing list