[Mesa-dev] [PATCH] targets/opencl: resolve undefined symbols at link time

Francisco Jerez currojerez at riseup.net
Sun Feb 23 12:50:31 PST 2014


Emil Velikov <emil.l.velikov at gmail.com> writes:

> Current automake build does not try to resolve undefined
> symbols thus we could end up with a broken library.
>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>

Looks good to me,
Reviewed-by: Francisco Jerez <currojerez at riseup.net>

> ---
>  src/gallium/targets/opencl/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/targets/opencl/Makefile.am b/src/gallium/targets/opencl/Makefile.am
> index 8eec405..91ec067 100644
> --- a/src/gallium/targets/opencl/Makefile.am
> +++ b/src/gallium/targets/opencl/Makefile.am
> @@ -4,6 +4,7 @@ lib_LTLIBRARIES = lib at OPENCL_LIBNAME@.la
>  
>  lib at OPENCL_LIBNAME@_la_LDFLAGS = \
>  	$(LLVM_LDFLAGS) \
> +	-no-undefined \
>  	-version-number 1:0
>  
>  lib at OPENCL_LIBNAME@_la_LIBADD = \
> -- 
> 1.9.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 229 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140223/1d30b037/attachment.pgp>


More information about the mesa-dev mailing list