[Mesa-dev] [PATCH] i965: Don't forget to subtract mt->first_level in minify calls.

Eric Anholt eric at anholt.net
Sun Feb 23 13:38:58 PST 2014


Kenneth Graunke <kenneth at whitecape.org> writes:

> This fixes fbo-clear-formats GL_ARB_depth_texture on Ironlake, which
> regressed since commit f128bcc7c293013f4b44e4b661638333de0077c2
> ("i965: Drop mt->levels[].width/height.")  intel_miptree_copy_slice was
> calling minify(.., 7) on a 2x2 texture with mt->first_level == 7.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=75292
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> Cc: Eric Anholt <eric at anholt.net>

Yuck, forgot about firstlevel -- not sure I'd have done the change if
I'd thought about it, but since you've written the patch let's go with
it.  Hopefully some day we can figure out how to kill firstlevel.

Reviewed-by: Eric Anholt <eric at anholt.net>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 818 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20140223/8ed7af59/attachment.pgp>


More information about the mesa-dev mailing list