[Mesa-dev] [PATCH] Gallium/dri2: Fix dri2_dup_image

Axel Davy axel.davy at ens.fr
Fri Jan 31 00:13:57 PST 2014


On 31/01/2014, Michel Dänzer wrote :
> On Don, 2014-01-30 at 16:10 +0100, Axel Davy wrote:
>> dri2_dup_image was not copying the dri_format field.
>>
>> This was causing some bugs, for example:
>> . we create an gbm_bo.
>> . we get an EGLImage from the gbm_bo.
>> . Bug: impossible to get again the gbm_bo from the EGLImage by importing. (gbm dri2 backend)
>>
>> Signed-off-by: Axel Davy <axel.davy at ens.fr>
>> ---
>>   src/gallium/state_trackers/dri/drm/dri2.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/src/gallium/state_trackers/dri/drm/dri2.c b/src/gallium/state_trackers/dri/drm/dri2.c
>> index 2a5b7b4..0589644 100644
>> --- a/src/gallium/state_trackers/dri/drm/dri2.c
>> +++ b/src/gallium/state_trackers/dri/drm/dri2.c
>> @@ -777,6 +777,7 @@ dri2_dup_image(__DRIimage *image, void *loaderPrivate)
>>      pipe_resource_reference(&img->texture, image->texture);
>>      img->level = image->level;
>>      img->layer = image->layer;
>> +   img->dri_format = image->dri_format;
>>      /* This should be 0 for sub images, but dup is also used for base images. */
>>      img->dri_components = image->dri_components;
>>      img->loader_private = loaderPrivate;
> Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>
>
> Do you have Git write access?
>
>
I don't have Git access, could you push the patch?

Thanks,

Axel Davy


More information about the mesa-dev mailing list